Repository navigation
Tours: registry moves to compositions, TourId derives from it - #1114
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the tour registry to
src/compositions/appTours.tsasAPP_TOUR_REGISTRY(satisfies Record<string, Tour>) and makesTourIdkeyofit, so adding a tour is one row instead of two edits. TheTourtype referencesTourIdand the registry referencesTour; this resolves fine under tsc.The tour content files (demoTour, webShowcase, grandTour, beats) are deliberately left in
src/data/animation/tours/because draft #1070 edits ~30 of them. They move tocompositions/tours/after #1070 lands.Ledger row: set to DONE (the hand-written union and the core table are gone; the row files are content, not a per-kind table). Tally now 25 DONE, 9 TODO.
The registry test moved with the file (
tests/compositions/appTours.test.ts); it checks id/key match, which the type cannot, so it stays.🤖 Generated with Claude Code