Make webrick dependency optional - #598
Merged
Merged
Conversation
Only required when Ferrum::Proxy is used
Member
|
Looking good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR proposes making the
webrickdependency optional, by removing it from the gemspec. It's only used byFerrum::Proxy.This is a breaking change, so user's would have to add
webrickto their Gemfile if it's not already present.Why
Fewer dependencies in our application means less time updating them & less surface area for supply chain attacks / vulnerabilities.
This PR was motivated by the recent CVE found in
webrick:https://nvd.nist.gov/vuln/detail/cve-2026-38969
Notes
Unfortunately Rubygems / Bundler doesn't have an API for specifying optional dependencies:
ruby/rubygems#1811
But the
rescue LoadError/ informative error message pattern seems fairly widespread as a method of handling optional dependencies in gems.