Skip to content

Don't use Regexp match for substring-after() XPath function #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 1 commit into from
Aug 17, 2026
+9 −2
Merged

Don't use Regexp match for substring-after() XPath function #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/rexml/functions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,13 @@ def substring_before( string, test )
# Kouhei fixed this too
def substring_after( string, test )
ruby_string = string(string)
return $1 if ruby_string =~ /#{test}(.*)/
""
ruby_test = string(test)
ruby_index = ruby_string.index(ruby_test)
if ruby_index.nil?
""
else
ruby_string[(ruby_index + ruby_test.length)..-1]
end
end

# Take equal portions of Mike Stok and Sean Russell; mix
Expand Down
2 changes: 2 additions & 0 deletions test/functions/test_base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,8 @@ def test_substring
def test_substring_angrez
testString = REXML::Functions::substring_after("helloworld","hello")
assert_equal( 'world', testString )
testString = REXML::Functions::substring_after("helloworld","hel.o")
assert_equal( '', testString )
end

def test_translate
Expand Down