Remove RDoc::Comment#{remove_private,extract_call_seq}#1706
Open
Earlopain wants to merge 1 commit into
Open
Conversation
Earlopain
requested a deployment
to
fork-preview-protection
GitHub Actions
Waiting
There was a problem hiding this comment.
Pull request overview
Removes the legacy RDoc::Comment#remove_private instance method and its unit tests now that private-section stripping is handled elsewhere (e.g., via RDoc::Comment.parse / parser behavior) following prior internal changes.
Changes:
- Deleted
RDoc::Comment#remove_privatefromlib/rdoc/comment.rb. - Removed the corresponding
remove_privatetest cases fromtest/rdoc/rdoc_comment_test.rb.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/rdoc/rdoc_comment_test.rb | Removes tests that only exercised the deleted RDoc::Comment#remove_private API. |
| lib/rdoc/comment.rb | Removes the now-obsolete remove_private instance method and its inline documentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
It was changed in ruby@b92986a and can now be removed entirely
Earlopain
force-pushed
the
comment-remove-private
branch
from
858d997 to
cdbdad7
Compare
Earlopain
requested a deployment
to
fork-preview-protection
GitHub Actions
Waiting
Earlopain
changed the title
RDoc::Comment#remove_privateRDoc::Comment#{remove_private,extract_call_seq}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was changed in b92986a and can now be removed entirely