I have noticed that unlike other omniauth providers the omniauth-openid gem passes a symbol :open_id instead of string as the provider name in the omniauth hash:
OmniAuth login details: {:uid=>"https://foobar.wordpress.com/", :provider=>:open_id, :info=>{}}
https://github.com/intridea/omniauth-openid/blob/master/lib/omniauth/strategies/open_id.rb#L24
Other providers:
Although the omniauth hash schema docs don't specify the type it does imply it should be a string:
https://github.com/intridea/omniauth/wiki/Auth-Hash-Schema
This is also implied when a provider name is not specified:
https://github.com/intridea/omniauth/blob/master/lib/omniauth/strategy.rb#L135
Of course this isn't a major issue as the name option can be specified in the provider initialisation step but it would be nice if this was consistent with other omniauth providers:
provider :open_id, :name => "open_id"
Of course this might break anyone's integrations if they were explicitly checking the auth hash provider as :open_id
Any thoughts on this would be great. Thanks in advance.
I have noticed that unlike other omniauth providers the
omniauth-openidgem passes a symbol:open_idinstead of string as the provider name in the omniauth hash:https://github.com/intridea/omniauth-openid/blob/master/lib/omniauth/strategies/open_id.rb#L24
Other providers:
Although the omniauth hash schema docs don't specify the type it does imply it should be a string:
https://github.com/intridea/omniauth/wiki/Auth-Hash-Schema
This is also implied when a provider name is not specified:
https://github.com/intridea/omniauth/blob/master/lib/omniauth/strategy.rb#L135
Of course this isn't a major issue as the
nameoption can be specified in the provider initialisation step but it would be nice if this was consistent with other omniauth providers:Of course this might break anyone's integrations if they were explicitly checking the auth hash provider as
:open_idAny thoughts on this would be great. Thanks in advance.