Repository navigation
docs: rebuild a tag by hand only while main holds its version - #103
Merged
Merged
Conversation
The checksum task and the publish job take the version from main, so steps 3 and 4 cannot publish the rebuilt tag of an older version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
RELEASE.md, "Manual / out-of-band release":Problem
Steps 3 and 4 take the version from
main.task checksum:downloaddownloads the tarballs of the@versionof the checkout, andrelease.yml:detectreadsmix.exsof the pushed commit. Say an owner rebuilds an unpublishedv0.5.0whilemainholds0.7.0: step 3 writes the0.7.0checksums, and the merge in step 4 publishesv0.7.0or nothing. The rebuiltv0.5.0can't reach Hex this way.After
Details
#98 kept a condition here: follow steps 3 and 4 only while
lib/,native/, andmix.exsonmainstill equal the tag. #101 moved the publish job to the sources of the tag and dropped the condition, but the version still comes frommain(release.yml:detect,git show "$SHA:mix.exs"). This PR brings back the part of the condition that still holds. Docs only, so no test.