Skip to content

Fix ruby 2.7 warnings#74

Open
PoroshkinaVV wants to merge 1 commit into
rtomayko:masterfrom
PoroshkinaVV:ruby2.7-warnings
Open

Fix ruby 2.7 warnings#74
PoroshkinaVV wants to merge 1 commit into
rtomayko:masterfrom
PoroshkinaVV:ruby2.7-warnings

Conversation

@PoroshkinaVV

Copy link
Copy Markdown

On running shotgun there was a warning
.rvm/gems/ruby-2.7.0/gems/shotgun-0.9.2/bin/shotgun:156: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

@ZimbiX ZimbiX left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this; I was about to work on a PR myself.

I've confirmed it's at least working with:

  • webrick 1.6.0
  • puma 5.0.2
  • thin 1.7.2
  • falcon 0.36.6

@jelaniwoods

Copy link
Copy Markdown

Shotgun fails in ruby 3.0.0 without this change. Is there an estimate on when this change will be released?

@casi

casi commented May 3, 2021

Copy link
Copy Markdown

I appreciate your commitment and look forward to its publication, hopefully soon.

@tom-lord tom-lord mentioned this pull request May 10, 2021
@aidistan

Copy link
Copy Markdown

Could we merge this PR ASAP? We need it desperately to run Shotgun with Ruby 3.

@kandalf

kandalf commented Dec 29, 2021

Copy link
Copy Markdown

It looks like this is not getting enough attention yet. I know it's not the best solution, but I've just released a "temporary" fork since I needed to use it with Ruby 3 and needed a gem to properly automate deployment and some scripting.

I'm leaving the link here for anybody that could find it useful until this PR is merged and we can all go back to the official gem.

Hope it helps.

@casi

casi commented Dec 29, 2021

Copy link
Copy Markdown

@kandalf thanks for your commitment, mate!

ZimbiX added a commit to ZimbiX/brendan-weibrecht-resume that referenced this pull request Aug 20, 2023
@ZimbiX

ZimbiX commented Jan 14, 2024

Copy link
Copy Markdown

Resolves #76

@astromoose

Copy link
Copy Markdown

Who do we need to poke with a stick to get this merged then? 💟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants