samples: cmsis_dsp: fix moving average on Helium - #293
Open
ZhiyuanTang17 wants to merge 1 commit into
Open
ZhiyuanTang17 wants to merge 1 commit into
ZhiyuanTang17 wants to merge 1 commit into
Conversation
The CMSIS-DSP Helium FIR Q31 implementation requires the state buffer to include temporary space. It also requires the coefficient array to be padded to a multiple of four entries. Size the sample buffers for that requirement when MVE is enabled so arm_fir_q31() does not access memory beyond the arrays. Signed-off-by: Zhiyuan Tang <zhiyuan_tang@realsil.com.cn> Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TO reproduce:
The code hangs at:
RTL87x2G uses a Cortex-M55 core with MVE support. The CMSIS-DSP
Helium FIR Q31 implementation requires extra state buffer space and
requires the coefficient array to be padded to a multiple of four
entries, so the sample needs to size those buffers accordingly.
After this change, the case can pass:
🤖 Generated with Claude Code