Repository navigation
fix(ci): select OpenSSL 3 for older macOS R - #76
Merged
Merged
Conversation
schloerke
reviewed
Nov 16, 2026
Comment on lines
+125
to
+140
| # Source builds of websocket with recent AsioHeaders need OpenSSL 3. | ||
| - name: Use OpenSSL 3 for older macOS R versions | ||
| if: >- | ||
| runner.os == 'macOS' && | ||
| (startsWith(steps.setup-r.outputs.installed-r-version, '4.2.') || | ||
| startsWith(steps.setup-r.outputs.installed-r-version, '4.3.') || | ||
| startsWith(steps.setup-r.outputs.installed-r-version, '4.4.')) | ||
| id: macos-openssl | ||
| shell: bash | ||
| run: | | ||
| openssl_pkgconfig="$(brew --prefix openssl@3)/lib/pkgconfig" | ||
| if [[ ! -f "$openssl_pkgconfig/openssl.pc" ]]; then | ||
| brew install openssl@3 | ||
| fi | ||
| echo "PKG_CONFIG_PATH=$openssl_pkgconfig${PKG_CONFIG_PATH:+:$PKG_CONFIG_PATH}" >> "$GITHUB_ENV" | ||
| echo "cache-suffix=-openssl3" >> "$GITHUB_OUTPUT" |
Collaborator
There was a problem hiding this comment.
please move inside setup-macOS-dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, R 4.2 through 4.4 can find OpenSSL 1.1 when it builds
websocketfrom source. Recent versions ofAsioHeadersneed OpenSSL 3.setup-macOS-dependenciesnow puts OpenSSL 3 from Homebrew first for those versions of R.setup-r-packageuses the cache suffix from that action to keep packages built with the two OpenSSL versions separate.The integration test calls both actions from this PR. It makes sure that R 4.4 finds OpenSSL 3 through the Homebrew path.
Requested in shinycoreci #389.