Repository navigation
Keep Sass compilation working when cache-directory lookup fails - #167
Merged
Merged
Conversation
On Windows, dirname() returns forward slashes while normalizePath() returns backslashes, and the dir.create() warning renders paths in 8.3 short-name form. Normalize both sides of the parent-directory assertions and make the snapshot transform match any quoted path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sass compilation now warns and uses a temporary cache when the default cache directory cannot be determined. Previously, the fallback itself failed with
object 'cache_dir' not found, which could prevent a Shiny application from starting.Initialize the cache path before lookup and include it in the fallback warning only when it is known. Regression tests cover lookup failure, directory creation failure, and compilation using the temporary cache.
Validation: the regression test reproduced the original error before the fix; the full package test suite passes afterward.
Fixes #93.