Forward error_call value in Pool$release

NEWS.md

@@ -1,5 +1,7 @@
 # pool (development version)
 
+* `Pool$release()` now forwards `error_call` correctly when reporting invalid objects.
+
 # pool 1.0.5
 
 * Added compatibility for dbplyr's upcoming dialect-based dispatch.

R/pool.R

@@ -78,7 +78,7 @@ Pool <- R6::R6Class(
     ## (sets up task to destroy the object if the number of
     ## total objects exceeds the minimum)
     release = function(object, error_call = caller_env()) {
-      pool_metadata <- pool_metadata(object, error_call = error_call())
+      pool_metadata <- pool_metadata(object, error_call = error_call)
       if (pool_metadata$state == "free") {
         abort(
           "This object was already returned to the pool.",

tests/testthat/_snaps/pool.md

@@ -25,6 +25,14 @@
       Error in `poolClose()`:
       ! The pool has been closed.
 
+# releasing a non-pooled object gives an informative error
+
+    Code
+      release(1)
+    Condition
+      Error in `release()`:
+      ! `object` is not an pooled object.
+
 # max size is enforced
 
     Code

tests/testthat/test-pool.R

@@ -37,6 +37,14 @@ test_that("can fetch and release", {
   checkCounts(pool, free = 1, taken = 0)
 })
 
+test_that("releasing a non-pooled object gives an informative error", {
+  pool <- poolCreate(function() 1)
+  defer(poolClose(pool))
+
+  release <- function(object) pool$release(object)
+  expect_snapshot(release(1), error = TRUE)
+})
+
 test_that("max size is enforced", {
   pool <- poolCreate(MockPooledObj$new, maxSize = 2)
   defer(poolClose(pool))