feat!: upgrade selfsigned to v5 to drop node-forge - #89
Merged
Merged
Conversation
chenjiahan
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selfsigned@3depends onnode-forge, which is flagged by security vulnerability scanners.selfsigned@5replacesnode-forgewith@peculiar/x509and the native WebCrypto API.This upgrade unblocks getsentry/sentry#125476, whose vulnerability check fails on the transitive
node-forgedependency:Changes
selfsigned v5 has two breaking changes that affect this plugin:
generate()is now async, so we await it.daysoption was removed in favor ofnotAfterDate. To avoid a breaking change for plugin users,selfsignedOptions.days(default30) is still accepted and converted tonotAfterDate. IfnotAfterDateis set,daysis ignored.The cached certificate is now reused based on its actual expiry date (read with
crypto.X509Certificate) instead of the file's mtime compared againstdays. This keeps working when users passnotAfterDate, and an unreadable cached file now triggers regeneration.Test plan
pnpm build,pnpm check,tsc --noEmitandpnpm testpassdays: 1produces a cert expiring in 1 day, that a valid cached cert is reused, that an invalid cached file is regenerated, and thatnotAfterDateis respected