Skip to content

Added generic overload of TaskBuilderV2.For method#32

Open
SLAVONchick wants to merge 2 commits into
rspeele:masterfrom
SLAVONchick:master
Open

Added generic overload of TaskBuilderV2.For method#32
SLAVONchick wants to merge 2 commits into
rspeele:masterfrom
SLAVONchick:master

Conversation

@SLAVONchick
Copy link
Copy Markdown

@SLAVONchick SLAVONchick commented May 16, 2020

This PR solves problem of iterating over sequences that don't implement IEnumerable<'T>, e.g. System.Buffers.ReadOnlySequence<'T>.

After applying the changes you should be able to compile code like this:

open System.Text
open System.Buffers
open FSharp.Control.Tasks.V2

let readFromSequence (seq: ReadOnlySequence<byte>) = task {
    for segment in seq do 
        printfn "%s" <| Encoding.UTF8.GetString segment.Span
}

Please, @rspeele, give some feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant