fix(console): omit missing timestamp instead of printing <nil> - #778
Open
Solaris-star wants to merge 1 commit into
Open
fix(console): omit missing timestamp instead of printing <nil>#778Solaris-star wants to merge 1 commit into
Solaris-star wants to merge 1 commit into
Conversation
ConsoleWriter always rendered a missing time field as the literal string "<nil>", which is especially confusing in Docker/container logs when the logger was created without .Timestamp(). Treat a nil timestamp value as empty so the part is skipped (spacing already handles empty parts). Fixes rs#725
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a logger is created without
.Timestamp(),ConsoleWriterstill reserved a timestamp column and printed the literal string<nil>:This is common in Docker/container setups and looks like a broken clock.
Fix
In
consoleDefaultFormatTimestamp, return an empty string when the timestamp value isnil.writePartalready skips empty parts and only inserts spacing between non-empty parts.Tests
Added
TestConsoleWriterOmitsNilTimestamp.Linked Issue
Closes #725