Skip to content

use pkl5 to enable bigger mpi messages - #339

Open
kmdalton wants to merge 5 commits into
mainfrom
mpi_pkl5
Open

use pkl5 to enable bigger mpi messages#339
kmdalton wants to merge 5 commits into
mainfrom
mpi_pkl5

Conversation

@kmdalton

@kmdalton kmdalton commented Apr 8, 2026

Copy link
Copy Markdown
Member

Addresses #338 to prevent mpi crashes when there are many more files than ranks.

@kmdalton
kmdalton requested a review from dermen April 8, 2026 14:11
@codecov-commenter

codecov-commenter commented Apr 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.75%. Comparing base (3e1622c) to head (5181abc).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
reciprocalspaceship/io/dials_mpi.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
- Coverage   86.78%   86.75%   -0.04%     
==========================================
  Files          40       40              
  Lines        2837     2838       +1     
==========================================
  Hits         2462     2462              
- Misses        375      376       +1     
Flag Coverage Δ
unittests 86.75% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JBGreisman JBGreisman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants