Fix alerts summary grid asset path#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the Alerts/Overview summary grid script include path in the main app shell.
The template was loading
/static/js/components/alerts_summary_grid.js, but the actual file lives at/static/js/components/alerts/alerts_summary_grid.js. Because of that, the Alerts page could receive/api/alertsdata successfully and still fail to render withReferenceError: renderAlertsSummaryGrid is not defined.Verification
Rebuilt the local image and redeployed the Helm chart on kind. After the fix, the Alerts page renders the ingested Alertmanager alert and the browser console has no
renderAlertsSummaryGriderror.