Skip to content
This repository was archived by the owner on Apr 26, 2026. It is now read-only.

Add Zsh support#2

Open
chenyao36 wants to merge 4 commits into
roxma:masterfrom
chenyao36:master
Open

Add Zsh support#2
chenyao36 wants to merge 4 commits into
roxma:masterfrom
chenyao36:master

Conversation

@chenyao36

@chenyao36 chenyao36 commented Feb 5, 2024

Copy link
Copy Markdown

Important diff to support zsh:

-if [ "$(jobs)" == "" ]
+if [[ "$(jobs)" = "" ]]

-    ENVRC_LOAD="{rc_found}" ENVRC_PPID=$$ $BASH
+    ENVRC_LOAD="{rc_found}" ENVRC_PPID=$$ $SHELL

Other diff:

  • change: envrc bash -> envrc hook;
  • new: envrc init bash and envrc init zsh;
  • refactor: cargo fmt; clap 2 builder -> clap 4 derive;

@runlevel5 runlevel5 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@roxma

roxma commented Jul 11, 2024

Copy link
Copy Markdown
Owner

This PR breaks existing config. I don't want to merge it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants