Repository navigation
fix: retain simultaneous primitive composition constraints - #380
Merged
Merged
Conversation
I preserve both anyOf and oneOf when they appear together on a primitive parameter schema instead of silently choosing oneOf and dropping anyOf. I added fail-first validation regressions for all parameter locations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A primitive parameter with both
anyOfandoneOfkept onlyoneOf, so a value that failed theanyOfwas accepted. I now keep both compositions in the generated schema.One edge case: an invalid empty
anyOf: []next to a primitiveoneOfnow falls back to Forge's narrowed view instead of using theoneOf.The new tests cover path, query, header and cookie parameters with an
anyOfminimum of 5 and aoneOfof integer or string, and check 5 is accepted while 4 and a string are rejected. They fail on main and pass with the change. Full suite passes, typecheck passes.Closes #379.