fix: retain root type and enum on primitive compositions - #378
Merged
Merged
Conversation
I keep sibling type and enum constraints when adapting primitive anyOf and oneOf parameter schemas, so branch alternatives cannot widen the root contract. I added fail-first regressions for path, query, header and cookie inputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a primitive
anyOforoneOfparameter also had a siblingtypeorenum, only the branches made it into the input schema, so the branches could widen the contract and accept values the root enum should reject. I now keep the roottypeandenumnext to the composition.This tightens schemas that were wrongly accepting values, for example
type: string, enum: ['a', null]now rejects null, as 3.1 says. An array-valuedtypewithanyOfis still widened, the same as before.The new tests cover path, query, header and cookie parameters, and check the schema keeps type and enum and that the validator rejects a value outside the root enum. They fail on main and pass with the change. Full suite passes, typecheck passes.
Closes #377.