fix: protect implicitly loaded config from output overwrite - #376
Merged
Merged
Conversation
I retain the default config path when the file exists and include it in output safety checks, matching explicitly selected config files. I added a fail-first CLI regression for output targeting the directory containing the implicitly loaded project settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without
--config, the CLI still loads./spec2mcp.config.jsonwhen it exists, but the output safety check only covered a config path passed explicitly. Sogenerate --out .could overwrite the user's project settings. I now keep the default config path when the file exists and use it in the output safety checks and the generate and watch paths, the same as an explicit config.The new CLI test puts a config in the folder, runs
generatewith--outset to that folder, expects the "output directory contains config input" error, and checks the config is unchanged. It fails on main and passes with the change. Full suite passes, typecheck passes.Closes #375.