fix: reject conflicting output file and directory paths - #374
Merged
Merged
Conversation
I validate the complete output layout before cleaning or writing so a file path cannot also be a directory needed by another generated file. I added a fail-first regression that preserves existing output on error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finalizechecked each file path on its own and then cleaned the output directory, so a layout where one file path is also the parent directory of another (subandsub/nested.txt) wiped the existing output and then failed on write. I now validate the whole layout before cleaning or writing and reject it with a "conflicting output paths" error.The new test uses that layout with
clean: true, expects the error, and checks an existing file in the output is untouched. It fails on main and passes with the change. Full suite passes, typecheck passes.Closes #373.