fix: retain required request bodies without schema constraints - #372
Merged
Merged
Conversation
I keep required bodies in the operation metadata even when their JSON schema is unconstrained, so tools cannot silently omit a required body. I added fail-first regressions for empty and object-only schemas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A required request body whose JSON schema has no constraints (
{}or{type: object}) was treated as empty and dropped, so the tool had no way to send the body the API requires. I now never treat a required body as empty, so the whole-body argument stays and is required.One widening: a required body with
content: {}and no media type also gets a required body argument now.The new tests cover
{}and{type: object}and check the content type, the requiredbodyinput and the whole-body field path. They fail on main and pass with the change. Full suite passes, typecheck passes. Mock-only, no live API call.Closes #371.