feat(linux): stage native desktop packages with declared tray dependencies - #1113
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| function listingDesktop(file) { | ||
| const dir = mkdtempSync(join(tmpdir(), "np-deb-extract-")); | ||
| execFileSync("dpkg-deb", ["-x", file, dir]); | ||
| return execFileSync("cat", [join(dir, "usr/share/applications/nowplaying.desktop")], { encoding: "utf8" }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #779.
Adds a shared staging step and builders for native Linux packages (
.deb,.rpm, Arch), with the tray's dependencies declared in each package.docs/linux-native-packages.mdhas the build commands.What this does not do: it only builds files. It does not install, publish, enable autostart or cut a release. It only accepts x86_64 and our own CI-generated Node bundle, which has to stay unchanged while packaging runs (documented in the doc).
Testing: the
.debbuilder and the staging step are covered by tests. The.rpmand Arch builders have not been executed yet, and none of the packages has been installed on a real distro; that needs a run on each target distro.