feat(linux): add native tray with WebUI menu and bounded lifecycle - #1111
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a tray icon on Linux desktops with a small menu to open the WebUI pages (home, settings, logs) and to quit nowplaying.
How it works:
scripts/linux-tray.pyis the tray helper. It gets only the icon path. It reports menu events over stdout, and Node only accepts a small fixed set of them. The helper cannot pass commands or URLs.src/linux-tray.jsstarts and stops the helper with bounded timeouts (ready timeout, SIGTERM then SIGKILL). Pages open throughxdg-openwith only the desktop session environment, and only for loopback 127.0.0.1 URLs on the allowed pages.scripts/nowplaying.jswires it in, and the POSIX build ships the helper.Testing: protocol and headless tests only (
test/linux-tray.test.js,test/unix-entry.test.js). I have not run it on a real Linux desktop, so real tray rendering and the menu behaviour are untested.