Skip to content

Add a Discord status text field to Settings - #1109

Merged
rowkav09 merged 1 commit into
mainfrom
feat-discord-name-settings
Oct 2, 2026
Merged

rowkav09 merged 1 commit into
mainfrom
feat-discord-name-settings

Conversation

@rowkav09

@rowkav09 rowkav09 commented Oct 2, 2026

Copy link
Copy Markdown
Member

Settings > Discord gets a "Status text" box and a "Status shows" choice, so the header text from #1098/#1105 can be changed without editing config.json.

  • Empty box = default "{artist} on {service}". The help lists the fields ({artist}, {title}, {subtitle}, {album}, {year}, {series}, {season}, {episode}, {service}) and says "{{ or }}" writes a literal brace.
  • "Status shows": the status text (default), the second line, or the first line (Discord's status_display_type).
  • Saved as discord.name / discord.statusDisplayType in config.json, kept across settings, server and setup rewrites, and passed to both the live and frozen Discord controllers. Left out when default, so existing configs are unchanged.
  • Name is limited to 128 characters; invalid values are rejected.

Fail-first: test/discord-name-settings.test.js (round trip, wire payload from a saved config, page markup and save script). Suite 1584 pass, 0 fail.

@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.00000% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/setup-config.js 66.66% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@rowkav09
rowkav09 force-pushed the feat-discord-name-settings branch from 22cb9ef to 44a6261 Compare October 2, 2026 17:43
@rowkav09
rowkav09 merged commit 6856efd into main Oct 2, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant