Skip to content

Stop labelling unrelated errors as Plex authentication failures #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rowkav09 merged 1 commit into from
Oct 2, 2026
Merged

Stop labelling unrelated errors as Plex authentication failures #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/worker/src/jobs/library-sync.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ describe('library sync failure sanitisation', () => {
[new PlexConnectionError('UNAUTHENTICATED', 'Plex rejected the supplied token.'), 'authentication', false],
[new PlexConnectionError('INVALID_RESPONSE', 'Plex returned an unreadable response.'), 'upstream_response', true],
['token=secret-value', 'unknown', true],
// A body that is not JSON is an odd answer from the server, not a rejected login.
[new SyntaxError('Unexpected token < in JSON at position 0'), 'upstream_response', true],
// A failed database write mentioning a token is not a Plex authentication failure.
[new Error('invalid input syntax for type uuid: bad token'), 'unknown', true],
] as const)('persists only stable safe details for %s', (error, classification, retryable) => {
const failure = sanitiseSyncFailure(error)

Expand Down
6 changes: 5 additions & 1 deletion apps/worker/src/jobs/library-sync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,16 @@ export function sanitiseSyncFailure(error: unknown): SanitisedSyncFailure {
}
return { classification: 'upstream_response', summary: 'Plex returned an unexpected response.', retryable: true }
}
// A body that is not JSON is an unexpected answer from the server, not a rejected login.
if (error instanceof SyntaxError) {
return { classification: 'upstream_response', summary: 'Plex returned an unexpected response.', retryable: true }
}
const message = error instanceof Error ? error.message.toLowerCase() : ''

if (message.includes('encryption') || message.includes('configuration') || message.includes('required before')) {
return { classification: 'configuration', summary: 'Sync configuration needs attention.', retryable: false }
}
if (message.includes('unauthor') || message.includes('forbidden') || message.includes('credential') || message.includes('token')) {
if (message.includes('unauthor') || message.includes('forbidden') || message.includes('credential') || (message.includes('plex') && message.includes('token'))) {
return { classification: 'authentication', summary: 'Plex authentication was rejected.', retryable: false }
}
if (message.includes('timeout') || message.includes('network') || message.includes('connect') || message.includes('unavailable')) {
Expand Down
Loading