fix: guard indexOf result in Bus.unsubscribe to prevent splice(-1)#526
Open
deepak0x wants to merge 1 commit intorowboatlabs:mainfrom
Open
fix: guard indexOf result in Bus.unsubscribe to prevent splice(-1)#526deepak0x wants to merge 1 commit intorowboatlabs:mainfrom
deepak0x wants to merge 1 commit intorowboatlabs:mainfrom
Conversation
Closes rowboatlabs#492 When unsubscribe() was called twice for the same handler, indexOf() returned -1 on the second call. splice(-1, 1) silently removed the last subscriber in the array — the wrong handler. Fix: store the indexOf result and only call splice when idx !== -1, making double-unsubscribe a safe no-op. Affected files: apps/cli/src/application/lib/bus.ts apps/x/packages/core/src/application/lib/bus.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #492
Problem
Bus.unsubscribe()calledsplice(indexOf(handler), 1)without checking the result ofindexOf. When the same unsubscribe function was called twice, the second call found no match and returned-1.splice(-1, 1)silently removed the last subscriber in the array — the wrong handler.Fix
Store the
indexOfresult and only callsplicewhenidx !== -1, making a double-unsubscribe a safe no-op.Files changed
apps/cli/src/application/lib/bus.tsapps/x/packages/core/src/application/lib/bus.ts