fix: bypass gateway for local model connection tests#472
Open
Bortlesboat wants to merge 1 commit intorowboatlabs:mainfrom
Open
fix: bypass gateway for local model connection tests#472Bortlesboat wants to merge 1 commit intorowboatlabs:mainfrom
Bortlesboat wants to merge 1 commit intorowboatlabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix issue #471 by making local provider connection tests bypass the Rowboat gateway even when the user is signed in.
Today
testModelConnection()routes all signed-in tests throughgetGatewayProvider(). That works for Rowboat-managed hosted models, but it breaks local providers because the gateway doesn't know local model ids likellama3.3:70borqwen3.5:latest.This patch keeps the current gateway behavior for hosted providers while always testing these local providers directly:
ollamaopenai-compatibleChanges
shouldUseGatewayForModelTest()inapps/x/packages/core/src/models/models.tstestModelConnection()to bypass the gateway for signed-in local providersapps/x/packages/core/src/models/models.test.tsTesting
pnpm testinapps/x/packages/coreollamabypasses the gatewayopenai-compatiblebypasses the gatewayNotes
I kept this intentionally narrow to the failing connection-test path. I did not change onboarding model-list behavior because the local-provider UI already falls back to manual model entry.
Fixes #471.