fix(editor): disable StarterKit Link to prevent duplicate extension warning#430
Open
aculich wants to merge 1 commit intorowboatlabs:mainfrom
Open
fix(editor): disable StarterKit Link to prevent duplicate extension warning#430aculich wants to merge 1 commit intorowboatlabs:mainfrom
aculich wants to merge 1 commit intorowboatlabs:mainfrom
Conversation
…arning StarterKit v3.x now includes the Link extension by default. The codebase separately adds Link.configure() with custom settings (openOnClick: false, custom HTMLAttributes). This caused the Tiptap warning: "Duplicate extension names found: ['link']" Disable StarterKit's built-in Link so the custom-configured one is used. Made-with: Cursor
|
@aculich is attempting to deploy a commit to the RowBoat Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
I checked the diff here against #433 and this is about as small as it gets: disable StarterKit's built-in If the duplicate-extension warning still reproduces on current
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes console warning: "Duplicate extension names found: ['link']"
Fixes #433
Problem
StarterKit v3.x now includes the Link extension by default. The codebase separately adds
Link.configure()with custom settings (openOnClick: false, custom HTMLAttributes), resulting in two Link extensions being registered.This causes:
Solution
Add
link: falseto StarterKit configuration to disable its built-in Link, allowing the custom-configured Link to be used exclusively.Changes
apps/x/apps/renderer/src/components/markdown-editor.tsx:link: falsetoStarterKit.configure()optionsTesting