Refactor: move model config parsing from renderer to main process via…#425
Open
tusharmagar wants to merge 1 commit intodevfrom
Open
Refactor: move model config parsing from renderer to main process via…#425tusharmagar wants to merge 1 commit intodevfrom
tusharmagar wants to merge 1 commit intodevfrom
Conversation
… IPC The renderer was reading config/models.json via workspace:readFile and manually parsing the provider/model structure. This moves that logic into a dedicated models:getConfiguredModels IPC handler backed by a new getAllConfiguredModels() method on the model config repo, matching the existing models:saveConfig pattern. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ramnique
reviewed
Mar 17, 2026
| } | ||
|
|
||
| async getAllConfiguredModels(): Promise<z.infer<typeof ConfiguredModelsResult>> { | ||
| const raw = await fs.readFile(this.configPath, "utf8"); |
Contributor
There was a problem hiding this comment.
why not call this.getConfig() which already does the internals of reading?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses code smells