Skip to content

Rftool refine rf2 integration#144

Open
gismo2004 wants to merge 7 commits into
rotorflight:masterfrom
gismo2004:rftool-refine-rf2-integration
Open

Rftool refine rf2 integration#144
gismo2004 wants to merge 7 commits into
rotorflight:masterfrom
gismo2004:rftool-refine-rf2-integration

Conversation

@gismo2004
Copy link
Copy Markdown

@gismo2004 gismo2004 commented May 30, 2026

What changed

  • expanded the widget options with HideModel, HideState, HideTelemetry, and TextColor
  • reworked the normal widget layout to fit text dynamically instead of using the fixed two-label layout
  • model-name changes trigger a refit with the correct font size
  • throw a warning if widget is used multiple times

@gismo2004 gismo2004 marked this pull request as draft May 30, 2026 08:27
Comment thread src/WIDGETS/RfTool/app.lua Outdated
@egonl
Copy link
Copy Markdown
Member

egonl commented May 30, 2026

What would be the use case for having several RF Tools widgets running at the same time? A considerable amount of code in this PR deals with making this possible, and it's unclear to me why I would like to do that.

@gismo2004
Copy link
Copy Markdown
Author

I absolutely agree that this is a monster and I already regretted to start with this. I stumple from one rabbit hole to the next one 🤦 however the main goal for me was to make it possible to have the widget in toolbar. When doing that one would loose the ability to open rf2 ui by switching to fullscreen. So I thought it would be a good idea to not loose this ability and that was where the nightmare started (having multiple instances) 😅 if you think that is too much, and it's not needed, I am happy to remove all that and make it a single tool again. Maybe with an notification that this widget can only be used once?

@gismo2004 gismo2004 marked this pull request as ready for review May 31, 2026 11:08
@gismo2004 gismo2004 marked this pull request as draft May 31, 2026 11:23
@gismo2004 gismo2004 marked this pull request as ready for review May 31, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants