Extend tests of the legacy version#259
Open
saikishor wants to merge 20 commits into
Open
Conversation
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
saikishor
force-pushed
the
extend/legacy_version/tests
branch
from
7494637 to
0c378f3
Compare
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
saikishor
force-pushed
the
extend/legacy_version/tests
branch
from
818a382 to
7666d01
Compare
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Contributor
Author
scpeters
reviewed
May 18, 2026
scpeters
left a comment
scpeters
left a comment
Contributor
There was a problem hiding this comment.
I love seeing new tests!
I have two thoughts:
-
All of these new tests use URDFs defined in string constants within a test. Alternatively they could be defined in separate files. There are trade-offs with each approach:
- Benefits of testing URDF string constants: URDF is defined right next to its test, making it easier to cross-reference between the two. You don't need to deal with loading from the filesystem. Don't need to choose filenames for the test URDFs.
- Benefits of testing URDF files: the test files can also serve as a reference, and are easier to reuse.
In sdformat, we use a mixture of both in our tests, but I've found the test files in the test/sdf folder rather useful as references. I suggest converting at least a few of the test URDF string constants to test files.
-
This test is over 2000 lines; I think it would be easier to navigate and interpret if it was split into multiple
.cppfiles
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Contributor
Author
|
@scpeters what do you think about the changes= |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is mainly to extend the tests of the legacy 1.0 version for most possible combinations of data