feat: use /ws/id and /ws/relay as default WebSocket paths - #24
Conversation
Bare `rustdesk` pattern was matching deploy/helm/rustdesk/ directory. Also exclude helm values override files containing private config.
Match the standard paths that RustDesk Pro and native clients use, instead of custom /hbbs and /hbbr paths that required rewrite rules.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
User description
Summary
/hbbs+/hbbrto/ws/id+/ws/relay, matching the standard paths used by RustDesk Pro and native clients.gitignoreto anchor rustdesk pattern to repo rootDetails
The previous
/hbbsand/hbbrpaths were custom and requiredrewriterules in the reverse proxy. The standard/ws/idand/ws/relaypaths are what hbbs/hbbr natively serve, so no rewrite is needed — simplifying proxy configuration.Runtime config via
config.json/RUSTDESK_HOST/RUSTDESK_RELAYenv vars still works and overrides these defaults.Test plan
/ws/idand/ws/relaythrough Istio VirtualServicePR Type
Enhancement, Tests, Documentation
Description
Change default WebSocket paths to standard endpoints
Align web client with native RustDesk clients
Update URL resolution unit tests accordingly
Revise README documentation and Nginx proxy examples
Diagram Walkthrough
File Walkthrough
url.test.ts
Update WebSocket paths in URL resolution unit testsflutter/web/js/src/url.test.ts
/hbbswith/ws/idacross all test cases/hbbrwith/ws/relayacross all test casesurl.ts
Change default WebSocket host and relay pathsflutter/web/js/src/url.ts
HOSTdefault value to/ws/idRELAY_HOSTdefault value to/ws/relayREADME.md
Update README with new default WebSocket pathsdocker/web-client/README.md