build: use component-prefixed tags for Docker releases - #23
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Change tag triggers from '*' to component-specific prefixes: - web-deps-*.*.* → rophy/rustdesk-web-deps - webclient-*.*.* → rophy/rustdesk-webclient Also add push-on-master with path filters for build-only validation, and fix stale Dockerfile path in web-docker.yml.
rophy
force-pushed
the
feat/component-tags
branch
from
August 23, 2026 08:36
cfbeef7 to
6e5f999
Compare
![npe-pr-agent[bot]](https://avatars.githubusercontent.com/u/592046?s=60&v=4){kind=small}
- Registry: ghcr.io/rophy/rustdesk/web-deps and web-client - Auth: GITHUB_TOKEN instead of DOCKERHUB secrets - Add packages:write permission - Rename webclient paths to web-client for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
tags: ['*']to component-specific prefixes:web-deps-*→rophy/rustdesk-web-depswebclient-*→rophy/rustdesk-webclientpush: branches: [master]with path filters for build-only validation on mergedeploy/docker/webclient/Dockerfilepath in web-docker.ymlThis avoids cross-triggering in a mono-repo where a single
v1.0.0tag would fire all tag-based workflows.Test plan
type=match,pattern=web-deps-(.*),group=1strips prefix correctly (e.g.web-deps-1.0.0→ image tag1.0.0)web-deps-0.1.0to verify end-to-end Docker Hub push (after merge)PR Type
Enhancement, Bug fix
Description
Use component-prefixed tags for Docker releases.
Add push-on-master triggers with path filters.
Correct Dockerfile path for webclient build.
Update Docker image tag extraction logic.
File Walkthrough
web-deps.yml
Update Docker web-deps workflow triggers and tagging.github/workflows/web-deps.yml
pushtrigger fromtags: ['*']totags: ['web-deps-*'].push: branches: [master]with path filters fordocker/web-deps/**and.github/workflows/web-deps.yml.docker/metadata-actionto extract tags usingtype=match,pattern=web-deps-(.*),group=1instead ofsemverpatterns.latesttag that is enabled only when pushing tags.web-docker.yml
Refine Docker webclient workflow triggers and paths.github/workflows/web-docker.yml
pushtrigger fromtags: ['*']totags: ['webclient-*'].push: branches: [master]with path filters for relevantflutter/and
docker/webclient/**paths.pull_requestandpushpathsfromdeploy/docker/webclient/Dockerfiletodocker/webclient/**.docker/metadata-actionto extract tags usingtype=match,pattern=webclient-(.*),group=1instead ofsemverpatterns.latesttag that is enabled only when pushing tags.filepath fordocker/build-push-action@v6fromdeploy/docker/webclient/Dockerfiletodocker/webclient/Dockerfile.