Skip to content

fix: enable keyboard input on web client #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rophy merged 2 commits into from
Aug 23, 2026
Merged

fix: enable keyboard input on web client #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45a8b70
chore: gitignore generated JS build artifacts
rophy Aug 22, 2026
341de05
fix: enable keyboard input on web client
rophy Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions flutter/lib/web/bridge.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,11 +373,7 @@ class RustdeskImpl {

bool sessionIsKeyboardModeSupported(
{required UuidValue sessionId, required String mode, dynamic hint}) {
if (mainGetInputSource(hint: hint) == 'Input source 1') {
return [kKeyMapMode, kKeyTranslateMode].contains(mode);
} else {
return [kKeyLegacyMode, kKeyMapMode].contains(mode);
}
return [kKeyLegacyMode, kKeyMapMode].contains(mode);
}

bool sessionIsMultiUiSession({required UuidValue sessionId, dynamic hint}) {
Expand Down Expand Up @@ -934,13 +930,9 @@ class RustdeskImpl {
}

String mainGetInputSource({dynamic hint}) {
final inputSource =
js.context.callMethod('getByName', ['option:local', 'input-source']);
// // js grab mode
// export const CONFIG_INPUT_SOURCE_1 = "Input source 1";
// // flutter grab mode
// export const CONFIG_INPUT_SOURCE_2 = "Input source 2";
return inputSource != '' ? inputSource : 'Input source 1';
// Input source 1 (OS-level hooks) is unavailable on web — always use
// Input source 2 (Flutter key events).
return 'Input source 2';
}

Future<void> mainSetInputSource(
Expand Down Expand Up @@ -1737,7 +1729,6 @@ class RustdeskImpl {

String mainSupportedInputSource({dynamic hint}) {
return jsonEncode([
['Input source 1', 'input_source_1_tip'],
['Input source 2', 'input_source_2_tip']
]);
}
Expand Down
4 changes: 4 additions & 0 deletions flutter/web/js/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,7 @@ dist-ssr
ogvjs
.vscode
.yarn
mise.toml
src/gen_js_from_hbb.ts
src/message.ts
src/rendezvous.ts
Loading