Pull from buerokratt/wip - #18
Merged
Merged
Conversation
Sync menu headers with other modules
* Cleaning: dedicated .txt / .md flow Plain-text inputs previously fell through to clean_any_file(), which calls unstructured.partition() and treats each line as a Title element. For real .txt content the output is noisy and pointless; for HTML mistakenly saved as .txt the output is the raw markup wrapped as "titles" — neither is useful. Add clean_plain_text() that just reads the file as UTF-8 with errors="replace" and returns the contents verbatim. The existing normalize_newlines() pass collapses whitespace at the call site, so we don't need any extraction step for formats that are already plain text. Route .txt and .md to the new helper. Other extensions still go through unstructured / pymupdf / trafilatura as before. Tests cover: - reading contents verbatim - bad UTF-8 bytes don't crash - .txt routes to clean_plain_text and NOT clean_any_file - .md routes the same way Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Tests: explicit utf-8 encoding on read/write_text calls Per Copilot review on #191: Path.read_text() / write_text() default to the platform locale, which is fine on Linux CI but would break the new plain-text tests on Windows (cp1252). Pin encoding="utf-8" on all three call sites so the tests are deterministic across platforms. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claudia kittask <claudia.kittask@mindtitan.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.