[rootcanvas] select canvas x11 window before closing it [6.40] - #23310
Open
linev wants to merge 2 commits into
Open
[rootcanvas] select canvas x11 window before closing it [6.40]#23310linev wants to merge 2 commits into
linev wants to merge 2 commits into
Conversation
Before it was hapenning in TCanvas::Close() but we removing gVirtualX from there. Therefore do it explicitely already in TRootCanvas::Close()
Now it happens in the canvas implementation and therefore not necessary.
couet
approved these changes
Sep 9, 2026
Test Results 18 files 18 suites 2d 22h 20m 30s ⏱️ Results for commit c0ad54e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of fixes from bigger PR
Correctly select canvas window in TRootCanvas before closing it.
Before
gVirtualX->SelectWindow(fCanvasID)was done in the TCanvas::Close(),but it was replaced by
fPainter->SelectDrawable(fCanvasID).For the case of GL it does not really select
gVirtualXwindow.After such change selection can be removed from TCanvas::Close()