[RF] Implement batch data access for RooCompositeDataStore - #23277
Merged
Conversation
Test Results 17 files 17 suites 2d 8h 49m 49s ⏱️ For more details on these failures, see this check. Results for commit 3f03c8a. |
dpiparo
approved these changes
Sep 7, 2026
Implement getBatches() and getCategoryBatches() for RooCompositeDataStore, which so far threw an exception. Like the existing getWeightBatch(), the implementation lazily concatenates the columns of the component datasets into internal buffers by loading the composite rows one by one. The index category, which is not stored in any of the component datasets, is synthesized from the row lookup. This is needed so that combined datasets backed by a composite storage (e.g. the output of generating from a RooSimultaneous with AllBinned()) can be loaded by the generic RooFit::Evaluator data path, which so far only worked when the dataset was split into its channel components first.
guitargeek
force-pushed
the
composite
branch
from
September 7, 2026 07:34
3f03c8a to
b582543
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement getBatches() and getCategoryBatches() for RooCompositeDataStore, which so far threw an exception. Like the existing getWeightBatch(), the implementation lazily concatenates the columns of the component datasets into internal buffers by loading the composite rows one by one. The index category, which is not stored in any of the component datasets, is synthesized from the row lookup.
This is needed so that combined datasets backed by a composite storage (e.g. the output of generating from a RooSimultaneous with AllBinned()) can be loaded by the generic RooFit::Evaluator data path, which so far only worked when the dataset was split into its channel components first.