[math] Remove TRolke model 1 - #23273
Open
yalok1 wants to merge 1 commit into
Open
Conversation
Numerical solution implemented in model 1 contains errors (wrong signs in lines 1068-1069 of LikeGradMod1) that may lead to wrong limits estimation. These errors can't be fixed without massive changes in algorithm. Detailed report about errors can be found here: https://github.com/y-maslov/TRolke-Model-1-Implementation-Errors AI disclosure: ChatGPT was used to assist with translating the technical report linked above from Russian into English. The technical analysis, identified issues, conclusions, and code changes were produced and reviewed by the authors.
yalok1
requested review from
couet,
dpiparo,
guitargeek and
hageboeck
as code owners
September 6, 2026 16:35
couet
removed their request for review
September 7, 2026 14:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numerical solution implemented in model 1 contains errors (wrong signs in lines 1068-1069 of LikeGradMod1) that may lead to wrong limits estimation. These errors can't be fixed without massive changes in algorithm.
Detailed report about errors can be found here:
https://github.com/y-maslov/TRolke-Model-1-Implementation-Errors
AI disclosure:
ChatGPT was used to assist with translating the technical report linked above from Russian into English. The technical analysis, identified issues, conclusions, and code changes were produced and reviewed by the authors.