[core] remove Strlen workaround from the 90s - #23255
Open
ferdymercury wants to merge 3 commits into
Open
Conversation
ferdymercury
added
the
skip code analysis
Test Results 23 files 23 suites 3d 16h 10m 7s ⏱️ Results for commit 0d7f88d. ♻️ This comment has been updated with latest results. |
ferdymercury
marked this pull request as ready for review
September 4, 2026 11:19
ferdymercury
requested review from
couet,
dpiparo,
jblomer,
linev and
pcanal
as code owners
September 4, 2026 11:19
pcanal
reviewed
Sep 4, 2026
| #ifndef ROOT_Strlen | ||
| #define ROOT_Strlen | ||
|
|
||
| #include <ROOT/RConfig.hxx> |
Member
There was a problem hiding this comment.
Could we replace this with a temporary 'empty' file with just a deprecation warning (and pointing to use cstring)? Or is it too unlikely to have been used outside of ROOT?
Collaborator
Author
There was a problem hiding this comment.
I'd say it's very unlikely, it was not used by any public header within ROOT, so hard anyone was coming up with the idea of searching among the 1280 ROOT headers one that does that, when there is cstring...
pcanal
reviewed
Sep 4, 2026
Co-authored-by: Philippe Canal <pcanal@fnal.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.