Skip to content

[core] deprecate RConfig.h and RVersion.h - #23253

Open
ferdymercury wants to merge 5 commits into
root-project:masterfrom
ferdymercury:patch-23
Open

[core] deprecate RConfig.h and RVersion.h#23253
ferdymercury wants to merge 5 commits into
root-project:masterfrom
ferdymercury:patch-23

Conversation

@ferdymercury

@ferdymercury ferdymercury commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

emit warning suggesting to use modern ROOT/* alternative.

@ferdymercury ferdymercury added the skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff. label Sep 4, 2026
@ferdymercury ferdymercury changed the title [core] deprecate RConfig.h [core] deprecate RConfig.h and RVersion.h Sep 4, 2026
jblomer
jblomer reviewed Sep 4, 2026
View reviewed changes

@jblomer jblomer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per our deprecation policy, we should leave deprecated components available for at least one LTS release. So we would need to target the release after 6.44 for removal.

@ferdymercury

ferdymercury commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator Author

As per our deprecation policy, we should leave deprecated components available for at least one LTS release. So we would need to target the release after 6.44 for removal.

thanks, fixed now

@ferdymercury
ferdymercury marked this pull request as ready for review September 4, 2026 11:18
@dpiparo dpiparo assigned dpiparo and unassigned hageboeck Sep 4, 2026
@dpiparo

dpiparo commented Sep 4, 2026

Copy link
Copy Markdown
Member

Thanks for this PR!! I assigned the PR to me as I think the commits could be re-organised, e.g. merged in a few groups. I can take care, and that does not remove any of the value of the changes themselves.

@github-actions

github-actions Bot commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 19h 38m 40s ⏱️
 3 883 tests  3 883 ✅ 0 💤 0 ❌
79 941 runs  79 941 ✅ 0 💤 0 ❌

Results for commit 3ab169d.

♻️ This comment has been updated with latest results.

@ferdymercury
ferdymercury requested a review from jblomer September 5, 2026 06:11
@ferdymercury
ferdymercury force-pushed the patch-23 branch 2 times, most recently from 8fd00e3 to de10863 Compare September 7, 2026 18:27
pcanal
pcanal approved these changes Sep 8, 2026
View reviewed changes

@pcanal pcanal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM

@ferdymercury
[core] deprecate RConfig.h
7dc358e 
[foundation] deprecate RConfig.h

[roottest] use modern include

[io] use modern include
@ferdymercury
[foundation] deprecate RVersion.h
272dd6d 
[foundation] rescue macro from deprecated header

[rversion] use modern alternative

[RF] use non deprecated include
@ferdymercury
[cmake] exclude deprecated RConfig/RVersion.h headers from module.mod…
72e40a1 
…ulemap
@ferdymercury
[RN] mention RConfig/RVersion.h header deprecation
29265a0
@ferdymercury
[nfc] copy-paste typo in endif comment
3ab169d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcanal pcanal pcanal approved these changes
@silverweed silverweed silverweed approved these changes
@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner
@lmoneta lmoneta Awaiting requested review from lmoneta lmoneta is a code owner
@guitargeek guitargeek Awaiting requested review from guitargeek guitargeek is a code owner
@hageboeck hageboeck Awaiting requested review from hageboeck hageboeck is a code owner
@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner
@jblomer jblomer Awaiting requested review from jblomer jblomer is a code owner

Assignees

@dpiparo dpiparo

Labels

pr:squash on merge skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ferdymercury @dpiparo @jblomer @pcanal @silverweed @hageboeck