[hist] Implement RProfileConcurrentFiller - #23248
Open
hahnjo wants to merge 3 commits into
Open
Conversation
I extended this test from one to two dimensions in commit 1e27e4c ("Integrate RHistStats into RProfile"), maybe because I was under the impression that the second dimension has a relation to the additional value argument. This is not needed, since the test already checks all combinations of std::tuple and variadic function, with RWeight and without.
Same concept as RHistConcurrentFiller and RHistFillContext, with one local RHistStats object per RProfileFillContext. The implementation is slightly more complex because of the additional variable.
Test Results 23 files 23 suites 3d 14h 4m 18s ⏱️ For more details on these failures, see this check. Results for commit a4948b1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same concept as
RHistConcurrentFillerandRHistFillContext, with one localRHistStatsobject perRProfileFillContext. The implementation is slightly more complex because of the additional variable.