Skip to content

[mathtext] sync with upstream 2016 version - #23198

Merged
linev merged 2 commits into
root-project:masterfrom
ferdymercury:bmathtextisosynch
Sep 1, 2026
Merged

[mathtext] sync with upstream 2016 version#23198
linev merged 2 commits into
root-project:masterfrom
ferdymercury:bmathtextisosynch

Conversation

@ferdymercury

@ferdymercury ferdymercury commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

To be applied after #23175

Supersedes #22476

Variant of #22462 but upgrading to latest version (2016) and decoupling from ROOT libs

It's basically the version of @yslai at https://github.com/yslai/mathtext/tree/master/src/libmathtext with just a few patches on top to solve compilation errors.

Future TO-DO items:

@ferdymercury ferdymercury added the skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff. label Aug 31, 2026
@ferdymercury
ferdymercury marked this pull request as ready for review August 31, 2026 12:13
@linev linev self-assigned this Aug 31, 2026
@linev

linev commented Aug 31, 2026

Copy link
Copy Markdown
Member

@ferdymercury

Did you check locally that all TMathText tutorials still working?
Changes are really significant in mathtext library.
Also does PNG/PDF output still works?

@ferdymercury

Copy link
Copy Markdown
Collaborator Author

Did you check locally that all TMathText tutorials still working?

Yep, I did. Looks fine. Both tutorials and their outputs.

Changes are really significant in mathtext library.
Also does PNG/PDF output still works?

PDF output never worked. Now it could work but needs changes in TPDF.cxx, so for a future PR.
PS and PNG outputs works as before.

@linev

linev commented Aug 31, 2026

Copy link
Copy Markdown
Member

PDF output never worked.

Yes, you are right.

If PS and PNG output still work - then it should be fine.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 10h 1m 36s ⏱️
 3 860 tests  3 858 ✅ 0 💤 2 ❌
74 899 runs  74 896 ✅ 1 💤 2 ❌

For more details on these failures, see this check.

Results for commit d1613ed.

♻️ This comment has been updated with latest results.

@ferdymercury

Copy link
Copy Markdown
Collaborator Author

Failures seem unrelated

Comment thread graf2d/postscript/src/TPDF.cxx Outdated
Comment thread builtins/libmathtext/mathtext/geometry.h Outdated
@couet
couet removed their request for review September 1, 2026 08:56
@ferdymercury

Copy link
Copy Markdown
Collaborator Author

(New CI failures are unrelated.)

@linev
linev merged commit 14f77c4 into root-project:master Sep 1, 2026
30 of 34 checks passed
@ferdymercury
ferdymercury deleted the bmathtextisosynch branch September 1, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants