[cmake] mv win32gdk to builtins - #23171
Open
ferdymercury wants to merge 27 commits into
Open
Conversation
ferdymercury
added
clean build
Test Results 23 files 23 suites 3d 17h 27m 9s ⏱️ For more details on these failures, see this check. Results for commit 13a48f6. ♻️ This comment has been updated with latest results. |
ferdymercury
commented
Aug 27, 2026
ferdymercury
commented
Aug 29, 2026
This comment was marked as outdated.
This comment was marked as outdated.
to avoid clash with std::byte
avoid undefined GetObject
for getcurrentthreadid
ferdymercury
marked this pull request as ready for review
August 31, 2026 15:36
ferdymercury
commented
Aug 31, 2026
ferdymercury
commented
Aug 31, 2026
ferdymercury
commented
Aug 31, 2026
Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
linev
reviewed
Sep 1, 2026
couet
removed their request for review
September 1, 2026 08:55
ferdymercury
commented
Sep 1, 2026
Collaborator
Author
|
CI failures seem unrelated |
Member
|
Let's wait for @bellenot to have a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To better separate externals from internals
In a future PR one could improve this by creating a native CMake build system rather than custom commands.