[ci] Add minimal asan build

.github/workflows/root-ci-config/build_root.py

@@ -59,7 +59,7 @@
         # the target branch in the ROOT repository using base_ref and head_ref:
         # - The base_ref is e.g. "master" or "v6-38-00-patches" 
         # - The head_ref for PRs is formatted as <PR branch>:<Fork branch> e.g. "refs/pull/20742/head:cppyy_fixup"
         if not ":" in args.head_ref:
             build_utils.print_error(f"This has been identified as a PR build. However, the head-ref is {args.head_ref}.")
         branch_in_fork = args.head_ref.split(":")[-1]
         if branch_in_fork == args.base_ref:
@@ -85,16 +85,17 @@
 
     if "minimal" in platform_options and platform_options["minimal"] == "ON":
         options_dict = platform_options
         print(f"Minimal build detected in the platform options. Ignoring global configuration.")
     else:
         options_dict.update(platform_options)
         print(f"Build option overrides for {args.platform_config}:")
         build_utils.print_options_diff(options_dict, last_options)
 
     if args.overrides is not None:
+        overrides = ' '.join(args.overrides).split('@')
         print("Build option overrides from command line:")
         last_options = dict(options_dict)
-        options_dict.update((arg.split("=", maxsplit=1) for arg in args.overrides))
+        options_dict.update((arg.split("=", maxsplit=1) for arg in overrides))
         build_utils.print_options_diff(options_dict, last_options)
 
     ctest_custom_flags = ""

.github/workflows/root-ci-config/buildconfig/alma10-minimal-asan.txt

@@ -0,0 +1,11 @@
+CMAKE_BUILD_TYPE=Debug
+CMAKE_CXX_FLAGS_DEBUG="-Og -g"
+asan=ON
+ccache=ON
+builtin_vdt=ON
+fail-on-missing=ON
+minimal=ON
+roottest=ON
+testing=ON
+LSAN_OPTIONS=verbosity=1:log_threads=1
+ROOT_CTEST_CUSTOM_FLAGS="-E \(cppinterop-CppInterOpTest\|roottest-cling-specialobj-runf02$\|roottest-root-collection-DeleteWarning$\|roottest-root-io-evolution-fixarr2$\|roottest-root-meta-rlibmap$\|roottest-root-treeproxy-vectorint-vectorint$\)"

.github/workflows/root-ci.yml

@@ -156,8 +156,8 @@
           HOME: /Users/sftnight
           INCREMENTAL: ${{ !contains(github.event.pull_request.labels.*.name, 'clean build') && !matrix.platform == 'mac15' && !matrix.platform == 'mac26'}}
           GITHUB_PR_ORIGIN: ${{ github.event.pull_request.head.repo.clone_url }}
-          OVERRIDES: ${{ join( matrix.overrides, ' ') }}
+          OVERRIDES: ${{ join( matrix.overrides, '@') }}
         run: |
           [ -d "${VIRTUAL_ENV_DIR}" ] && source ${VIRTUAL_ENV_DIR}/bin/activate
           echo "Python is now $(which python3) $(python3 --version)"
           src/.github/workflows/root-ci-config/build_root.py  \
@@ -170,7 +170,7 @@
                     --head_sha        ${{ github.event.pull_request.head.sha }}             \
                     --repository      ${{ github.server_url }}/${{ github.repository }}     \
                     --platform        ${{ matrix.platform }}                                \
-                    --overrides       ${GLOBAL_OVERRIDES} ${OVERRIDES}
+                    --overrides       "${GLOBAL_OVERRIDES}" "${OVERRIDES}"
 
       - name: Workflow dispatch
         if: ${{ github.event_name == 'workflow_dispatch' && !matrix.is_special }}
@@ -287,7 +287,7 @@
           INCREMENTAL: ${{ !contains(github.event.pull_request.labels.*.name, 'clean build') }}
           GITHUB_PR_ORIGIN: ${{ github.event.pull_request.head.repo.clone_url }}
         shell: cmd
         run: "C:\\setenv.bat ${{ matrix.target_arch }} &&
               python .github/workflows/root-ci-config/build_root.py
                     --buildtype       ${{ matrix.config }}
                     --platform        windows10
@@ -415,6 +415,12 @@
             is_special: true
             property: "clang Ninja builtins auto-registration off"
             overrides: ["CMAKE_CXX_STANDARD=20"]
+          # Asan build
+          - image: alma10
+            platform_config: alma10-minimal
+            is_special: true
+            property: "asan"
+            overrides: ["ROOT_CTEST_CUSTOM_FLAGS='-E \\(^tutorial-\\|cppinterop-CppInterOpTest\\|roottest-cling-specialobj-runf02$\\|roottest-root-collection-DeleteWarning$\\|roottest-root-io-evolution-fixarr2$\\|roottest-root-meta-rlibmap$\\|roottest-root-treeproxy-vectorint-vectorint$\\)'"]
           # Fedora Rawhide with Python freethreading+debug build
           - image: rawhide
             python_venv: "/py-venv-3.15td/ROOT-CI"
@@ -448,7 +454,7 @@
       - self-hosted
       - linux
       - ${{ matrix.architecture == null && 'x64' || matrix.architecture }}
       - ${{ matrix.extra-runs-on == null && 'cpu' || matrix.extra-runs-on }}
 
     name: |
       ${{ matrix.image }} ${{ matrix.property }}
@@ -515,7 +521,7 @@
           INCREMENTAL: ${{ !contains(github.event.pull_request.labels.*.name, 'clean build') }}
           GITHUB_PR_ORIGIN: ${{ github.event.pull_request.head.repo.clone_url }}
           OVERRIDES: ${{ join( matrix.overrides, ' ') }}
         run: ".github/workflows/root-ci-config/build_root.py
                     --buildtype       RelWithDebInfo
                     --platform        ${{ matrix.image }}
                     --platform_config ${{ matrix.platform_config }}

cmake/modules/RootBuildOptions.cmake

@@ -190,7 +190,7 @@ option(minimal "Enable only required options by default" OFF)
 option(rootbench "Build rootbench if rootbench exists in root or if it is a sibling directory (implies testing=ON)" OFF)
 option(roottest "Build roottest (implies testing=ON)" OFF)
 option(testing "Enable testing with CTest" OFF)
-option(asan "Build ROOT with address sanitizer instrumentation" OFF)
+option(asan "Build ROOT with address sanitizer instrumentation (only GCC is currently supported)" OFF)
 
 set(gcctoolchain "" CACHE PATH "Set path to GCC toolchain used to build llvm/clang")
 

core/sanitizer/SanitizerSetup.cxx

@@ -31,7 +31,8 @@ const char* __asan_default_options() {
          ":detect_container_overflow=1"
          ":alloc_dealloc_mismatch=0"
          DETECT_LEAKS
-         ":verify_asan_link_order=0";
+         ":verify_asan_link_order=0"
+         ":halt_on_error=0";
 }
 
 /// Default options when leak sanitizer starts up in ROOT executables.