[ntuple] Add RNTupleLocatorMulti class for kTypeMulti locator - #22577
Merged
jblomer merged 1 commit intoJun 23, 2026
Conversation
jblomer
reviewed
Jun 16, 2026
jblomer
left a comment
jblomer
left a comment
Contributor
There was a problem hiding this comment.
Nice! Some simplification is possible, I think, by not storing reserved bits altogether.
Test Results 21 files 21 suites 3d 9h 15m 15s ⏱️ Results for commit 8ec164f. ♻️ This comment has been updated with latest results. |
JasMehta08
force-pushed
the
ntuple-locator-multi-class
branch
from
June 18, 2026 09:17
0d8ca56 to
a78d828
Compare
jblomer
approved these changes
Jun 18, 2026
Contributor
|
It would be good to also update the PR details. |
silverweed
reviewed
Jun 18, 2026
JasMehta08
force-pushed
the
ntuple-locator-multi-class
branch
from
June 21, 2026 12:11
a78d828 to
957239d
Compare
JasMehta08
force-pushed
the
ntuple-locator-multi-class
branch
from
June 21, 2026 12:15
957239d to
8ec164f
Compare
Contributor
Author
|
@jblomer and @silverweed I have made the changes according to the comments please let me know if there is anything that I should change further |
silverweed
approved these changes
Jun 23, 2026
silverweed
left a comment
silverweed
left a comment
Contributor
There was a problem hiding this comment.
@JasMehta08 thanks! When the CI is green it can be merged for me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
(Is a part of the GSoC 2026 project
S3 Backend for RNTuple.)Changes or fixes:
Follow-up to #22434. Introduces a dedicated
RNTupleLocatorMulticlass for thekTypeMultilocator, replacing the previous reuse ofRNTupleLocatorObject64.The class stores the object identifier and byte offset as two
uint32_tfields and exposes them viaGetObjectId()/GetOffset(). The 32/32 packing intoRNTupleLocator::fPositionis the only place the in-memory layout shows up, and it lives insideSetPosition(RNTupleLocatorMulti)andRNTupleLocatorHelper<RNTupleLocatorMulti>::Get.RNTupleLocator::SetPositionandGetPosition<>are split accordingly soRNTupleLocatorObject64is now reserved forkTypeObject64only, and the newRNTupleLocatorMultioverload/specialization handlekTypeMulti.Checklist:
This PR is a follow-up #22434