[jupyter] use display.Javascript to embed custom JS code - #22522
Merged
Conversation
In previous implementation only display.HTML with embed <script></script> was used. But dependeing from security settings jupyter or web browser blocks loading of such <script> tag directly. Therefore split cell output to `display.HTML()` and `display.Javascript()`. This clearly indicates that JS code wants to be embed and therefore security settings should not block output. Can help to resolve issue in https://root-forum.cern.ch/t/64882/
Test Results 22 files 22 suites 3d 16h 25m 32s ⏱️ For more details on these failures, see this check. Results for commit 431f0bd. |
dpiparo
self-requested a review
June 8, 2026 19:47
dpiparo
approved these changes
Jun 8, 2026
dpiparo
left a comment
dpiparo
left a comment
Member
There was a problem hiding this comment.
thanks. Are backports needed?
Member
Author
|
Backport is not needed - it is new feature and not bugfix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In previous implementation only
display.HTML()with embed<script></script>was used. But depending from security settings jupyter or web browser blocks loading of such<script>inside HTML code. Therefore split cell output todisplay.HTML()anddisplay.Javascript(). This clearly indicates that JS code wants to be embed and therefore security settings should not block output.Can help to resolve issue in https://root-forum.cern.ch/t/64882/