Skip to content

[jupyter] remove wrong div closure from html #22495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linev merged 1 commit into from
Jun 8, 2026
Merged

[jupyter] remove wrong div closure from html #22495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions bindings/pyroot/pythonizations/python/ROOT/_jupyroot/helpers/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@

_jsCode = """
{jsDivHtml}
</div>
<script>
function process_{jsDivId}() {{
function execCode(Core) {{
Expand Down Expand Up @@ -119,47 +118,6 @@
</script>
"""


_jsFileCode = """
<div style="width: 100%; height: {jsCanvasHeight}px; position: relative">
<div id="{jsDivId}">
</div>
</div>
<script>
function process_{jsDivId}() {{
function showFile(Core) {{
Core.settings.HandleKeys = false;
const binaryString = atob('{fileBase64}');
const bytes = new Uint8Array(binaryString.length);
for (let i = 0; i < binaryString.length; i++)
bytes[i] = binaryString.charCodeAt(i);
Core.buildGUI('{jsDivId}','notebook').then(h => h.openRootFile(bytes.buffer));
}}
const servers = ['/static/', 'https://root.cern/js/7.11.0/', 'https://jsroot.gsi.de/7.11.0/' ],
path = 'build/jsroot';
if (typeof JSROOT !== 'undefined')
showFile(JSROOT);
else if (typeof requirejs !== 'undefined') {{
servers.forEach((s,i) => {{ servers[i] = s + path; }});
requirejs.config({{ paths: {{ 'jsroot' : servers }} }})(['jsroot'], showFile);
}} else {{
const config = document.getElementById('jupyter-config-data');
if (config)
servers[0] = (JSON.parse(config.innerHTML || '{{}}')?.baseUrl || '/') + 'static/';
else
servers.shift();
function loadJsroot() {{
return !servers.length ? 0 : import(servers.shift() + path + '.js').catch(loadJsroot).then(() => showFile(JSROOT));
}}
loadJsroot();
}}
}}
process_{jsDivId}();
</script>
"""



TBufferJSONErrorMessage = "The TBufferJSON class is necessary for JS visualisation to work and cannot be found. Did you enable the http module (-D http=ON for CMake)?"


Expand Down
Loading