[etc,config,core] remove leftover Makefiles or add deprecation warnings - #21894
Conversation
Test Results 21 files 21 suites 3d 7h 11m 34s ⏱️ Results for commit 2f3dea8. ♻️ This comment has been updated with latest results. |
linev
left a comment
There was a problem hiding this comment.
Makefile.arch, Makefile.config, Makefile.comp are files which were used by external projects for compilation.
I would not delete them now.
We should first fully free ROOT itself from all Makefiles
After #21890 goes in, we're almost there. Then, there are only 21 Makefiles left, all within roottest: They don't seem long, so doable, but I am not well acquainted with roottest infrastructure, so I won't be able to convert those myself. |
It probably make sense to replace them (for a release or two) by almost empty files with a error message when used. |
I added a deprecation warning and we can then remove them after November's 6.42 ? |
|
@ferdymercury, this needs a rebase. Also, our users prefer clear removal schedules for planning. If we're not in a rush to remove this, what about "will be removed in ROOT 7?" |
Review addressed by not removing the Makefiles. Instead, they are deprecated with a long deprecation Window, and only removed in ROOT 7.
Split-off #21820 as requested by @pcanal and @linev