Skip to content

[etc,config,core] remove leftover Makefiles or add deprecation warnings - #21894

Merged
guitargeek merged 3 commits into
root-project:masterfrom
ferdymercury:etcleft
Jun 19, 2026
Merged

[etc,config,core] remove leftover Makefiles or add deprecation warnings#21894
guitargeek merged 3 commits into
root-project:masterfrom
ferdymercury:etcleft

Conversation

@ferdymercury

Copy link
Copy Markdown
Collaborator

Split-off #21820 as requested by @pcanal and @linev

@github-actions

github-actions Bot commented Apr 12, 2026

Copy link
Copy Markdown

Test Results

    21 files      21 suites   3d 7h 11m 34s ⏱️
 3 868 tests  3 868 ✅ 0 💤 0 ❌
73 811 runs  73 811 ✅ 0 💤 0 ❌

Results for commit 2f3dea8.

♻️ This comment has been updated with latest results.

linev
linev previously requested changes Apr 13, 2026

@linev linev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makefile.arch, Makefile.config, Makefile.comp are files which were used by external projects for compilation.
I would not delete them now.

We should first fully free ROOT itself from all Makefiles

@ferdymercury

Copy link
Copy Markdown
Collaborator Author

We should first fully free ROOT itself from all Makefiles

After #21890 goes in, we're almost there.

Then, there are only 21 Makefiles left, all within roottest:

scripts/Makefile
scripts/Makefile.template
Makefile
root/io/evolution/versions/lhcb/Makefile
root/io/withoutDictionaries/Makefile
root/Makefile
root/rint/Makefile
root/treeformula/Makefile
root/meta/Makefile
root/meta/autoloading/headerParsingOnDemand/Makefile
root/meta/autoloading/classInNamespace/Makefile
root/meta/ROOT-7181/Makefile
root/meta/genreflex/ROOT-5594/Makefile
root/meta/genreflex/ROOT-5626/Makefile
root/meta/iotypeioname/Makefile
root/meta/rootcling/Makefile
root/meta/rootcling/ROOT-7695/Makefile
root/tree/Makefile
root/tree/readfile/Makefile
root/tree/cache/Makefile
root/tree/addresses/Makefile

They don't seem long, so doable, but I am not well acquainted with roottest infrastructure, so I won't be able to convert those myself.

@pcanal

pcanal commented Jun 5, 2026

Copy link
Copy Markdown
Member

Makefile.arch, Makefile.config, Makefile.comp are files which were used by external projects for compilation.

It probably make sense to replace them (for a release or two) by almost empty files with a error message when used.

@ferdymercury ferdymercury changed the title [etc,config,core] remove leftover Makefiles [etc,config,core] remove leftover Makefiles or add deprecation warnings Jun 6, 2026
@ferdymercury
ferdymercury requested a review from linev June 6, 2026 08:54
@ferdymercury

Copy link
Copy Markdown
Collaborator Author

Makefile.arch, Makefile.config, Makefile.comp are files which were used by external projects for compilation.

It probably make sense to replace them (for a release or two) by almost empty files with a error message when used.

I added a deprecation warning and we can then remove them after November's 6.42 ?

@guitargeek

Copy link
Copy Markdown
Contributor

@ferdymercury, this needs a rebase.

Also, our users prefer clear removal schedules for planning. If we're not in a rush to remove this, what about "will be removed in ROOT 7?"

@guitargeek guitargeek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@guitargeek
guitargeek dismissed linev’s stale review June 19, 2026 06:22

Review addressed by not removing the Makefiles. Instead, they are deprecated with a long deprecation Window, and only removed in ROOT 7.

@guitargeek
guitargeek merged commit 3a93c8a into root-project:master Jun 19, 2026
32 of 33 checks passed
@ferdymercury
ferdymercury deleted the etcleft branch June 19, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants