Skip to content

Bump grpcio to 1.53.2#321

Open
julietshen wants to merge 1 commit into
mainfrom
bump-grpcio
Open

Bump grpcio to 1.53.2#321
julietshen wants to merge 1 commit into
mainfrom
bump-grpcio

Conversation

@julietshen
Copy link
Copy Markdown
Member

Summary

  • Bumps the grpcio family from 1.49.11.53.2 to fix GHSA-cfgp-2977-2fmm (high-severity DoS via excessive iteration in gRPC).
  • Aligns grpcio, grpcio-status, grpcio-tools, grpcio-health-checking, grpcio-reflection on a single version (1.53.2).
  • Removes the platform_machine split — that was a workaround for missing aarch64 wheels at 1.49.1; 1.53.2 ships wheels for both x86_64 and aarch64.

Closes #316. Part of the Dependabot triage tracked in #219.

Test plan

  • uv lock + uv sync --dev — resolves cleanly
  • uv run ruff check — clean
  • uv run ruff format --check — clean
  • uv tool run fawltydeps --check-unused --pyenv .venv — no unused deps
  • Imported every *_pb2* module in osprey_rpc against the new runtime — all 18 load cleanly
  • Spot-checked the gRPC APIs Osprey uses: ServicerContext, StatusCode, intercept_channel, insecure_channel, grpc_health.v1.health_pb2, grpc_reflection.v1alpha.reflection — all present
  • Engine test suite (804 tests) passes; the 43 errors are the pre-existing KeyError: 'POSTGRES_HOSTS' and require the docker-compose stack — unrelated to this change
  • CI integration suite (./run-tests.sh) — will run in CI

osprey_coordinator (Rust) is unaffected: it uses tonic/prost, not the Python grpcio runtime.

🤖 Generated with Claude Code

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

Warning

Review limit reached

@julietshen, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 27 minutes and 36 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 14776842-a487-4582-946e-5ec46cca8149

📥 Commits

Reviewing files that changed from the base of the PR and between cf452c9 and e501387.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-grpcio

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

`grpcio==1.49.1` is affected by GHSA-cfgp-2977-2fmm (high-severity DoS
via excessive iteration). Fixed in 1.53.2+.

Bumps the whole grpcio family — `grpcio`, `grpcio-status`,
`grpcio-tools`, `grpcio-health-checking`, `grpcio-reflection` — to a
unified `1.53.2`. This also removes the `platform_machine` split that
existed because 1.49.1 lacked aarch64 wheels; 1.53.2 has wheels for both
arches.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@julietshen
Copy link
Copy Markdown
Member Author

Pushed f3ba8db to fix the integration-test failure.

Root cause: grpcio 1.53.x added validate_port_binding_result which raises when add_insecure_port returns 0 (the C-core's signal for a failed bind). In grpcio 1.49.1 this was returned silently — so a hardcoded port that couldn't actually be bound let tests proceed against a server that was never listening. test_retry.py::test_find_in_primary and friends "passed" only because most call paths route to SERVICE_1, not the unreachable SERVICE_2 on port 50054.

Fix: switch both test_retry.py and test_integration.py to bind '[::]:0' (OS-assigned ephemeral port) and capture the actual port from add_insecure_port's return value. Mutate the module-level Service objects in place so mock_select still sees the right routes.

Standalone benefit: tests are now immune to port collisions in CI runners and to whatever bind-validation behavior future grpcio releases ship.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump grpcio to 1.53.x (CVE-2023-32731)

1 participant